[Serverless Mini Agent] Run in Azure Spring Apps #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k with java tracer
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #547 +/- ##
=======================================
Coverage ? 70.44%
=======================================
Files ? 213
Lines ? 28455
Branches ? 0
=======================================
Hits ? 20044
Misses ? 8411
Partials ? 0
|
BenchmarksThis comment was omitted because it was over 65536 characters.Please check the Gitlab Job logs to see its output. |
danielsn
pushed a commit
that referenced
this pull request
Jul 31, 2024
* add azure spring app environment type for serverless mini agent * add config.statsd_port to mini agent info endpoint * update mini agent trace endpoint status code and response body to work with java tracer * use different environment variable to identify azure spring apps * only update http response for success responses to traces endpoint * address lint errors * updates comment and formatting * update trace-mini-agent description to include Azure Spring Apps * fix formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates Serverless Mini Agent to run in Azure Spring Apps.
Motivation
Additional Notes
ASCSVCRT_SPRING__APPLICATION__NAMEenvironment variable to determine if mini agent is running in an Azure Spring Apps environmentinfoendpoint so Datadog Java Tracer knows where to send trace metrics whenDD_TRACE_TRACER_METRICS_ENABLEDistrueconfig.statsd_port/v0.4/tracesendpoint to work with Datadog Java Tracermessageto{"rate_by_service":{"service:,env:":1}. This is just a placeholder to satisfy the response requirement by the Datadog Java Tracer but will need to be updated in a future PR to properly set the trace sampling priorityrate_by_servicehere: question: what is rate_by_service? datadog-agent#3031 (comment)Error from Datadog Java Tracer when Mini Agent trace endpoint returns 200 - OK status code
Error from Datadog Java Tracer when Mini Agent trace endpoint returns json with
messageinstead of json withrate_by_serviceHow to test the change?
-javaagent:/persistent/dd-java-agent.jarto the JVM optionsDD_TRACE_TRACER_METRICS_ENABLEDtotrue